Re: [PATCH 2/2] GCC release 8 support for gcc-plugins

[Kees Cook]

On Tue, Feb 13, 2018 at 6:56 AM, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:
> On Sun, Feb 04, 2018 at 12:34:38PM -0500, valdis.kletnieks@xxxxxx wrote:
>> For reasons totally beyond my understanding, gcc 8 changed the
>> order of two structure member, which leads to an error:
>
> I'm a little late on this, but isn't the whole point of C99 initializers
> that field order should not matter at all?

For C99, this is true. The plugins are built differently and follow
C++ conventions, which, for reasons I cannot understand, are ordered.
:( Regardless, the fix actually results in fewer lines of code, so
this is fine.

-Kees

-- 
Kees Cook
Pixel Security