Re: [PATCH] iommu/amd - Use dev_err to send events to the system log

[Hook, Gary]

On 2/13/2018 8:22 AM, Joerg Roedel wrote:
> On Tue, Jan 30, 2018 at 07:04:27PM -0600, Gary R Hook wrote:
> > +		dev_err(dev, "ILLEGAL_DEV_TABLE_ENTRY device=%02x:%02x.%x "
> > +			"address=0x%016llx flags=0x%04x]\n",
> > +			PCI_BUS_NUM(devid), PCI_SLOT(devid), PCI_FUNC(devid),
> > +			address, flags);
>
> That prints the PCI device-name of the IOMMU in front of the message. Is
> that actually helpful?
>
> If at all, we should print the name of the iommu-device in front of the
> message, not the PCI device that hosts the IOMMU.

so (e.g.):

        dev_err(&iommu->dev->dev, "ILLEGAL...

?

I'm okay with that. It does make more sense.

Gary