Re: [patch] kvm: suppress KVM_SET_GSI_ROUTING allocation failure

From: Michal Hocko
Date: Tue Feb 13 2018 - 10:58:22 EST


On Tue 13-02-18 16:49:20, Paolo Bonzini wrote:
> On 13/02/2018 16:44, Michal Hocko wrote:
> > On Tue 13-02-18 16:03:09, Paolo Bonzini wrote:
[...]
> >> There have been quite a few reports of this from syzkaller and generally
> >> we've fixed them. It does seem like a recipe for NULL-pointer
> >> dereferences when the size is user-controlled (as in this case).
> >
> > We do return NULL for that case regardless the above. The patch just
> > doesn't warn. Or do you think it is helpful to warn?
>
> It certainly helps bringing potential issues in the spotlight (through
> fuzzing, mostly).

Fair enough.

--
Michal Hocko
SUSE Labs