Re: [PATCH] iommu/amd - Use dev_err to send events to the system log

From: Hook, Gary
Date: Tue Feb 13 2018 - 14:25:10 EST


On 2/13/2018 11:00 AM, Joerg Roedel wrote:
On Tue, Feb 13, 2018 at 10:47:55AM -0500, Hook, Gary wrote:

dev_err(&iommu->dev->dev, "ILLEGAL...

I think its more something like iommu->iommu->dev.




Without actually running a driver and getting some debug info, I'll just
say that my example compiled, the amd_iommu structure points to a pci_dev which contains a device, and the two possibilities are likely equivalent.

I'll vet that, of course, but working under the assumption that they are equivalent, the question becomes, do you have a preference?

Thanks,
Gary