Re: [PATCH] mm/gup: Fixed coding style error and warnings.

From: Joe Perches
Date: Tue Feb 13 2018 - 14:32:57 EST


You should have a changelog.

On Tue, 2018-02-13 at 14:17 -0500, Mario Leinweber wrote:
[]
> diff --git a/mm/gup.c b/mm/gup.c
[]
> @@ -1635,7 +1640,7 @@ static int gup_pmd_range(pud_t pud, unsigned long addr, unsigned long end,
> PMD_SHIFT, next, write, pages, nr))
> return 0;
> } else if (!gup_pte_range(pmd, addr, next, write, pages, nr))
> - return 0;
> + return 0;

And of all these changes, this might be the only really useful one
as the
indentation is misleading.