Re: [PATCH] selftests/futex: Fix line continuation in Makefile
From: Darren Hart
Date: Tue Feb 13 2018 - 21:04:01 EST
On Tue, Feb 13, 2018 at 06:45:54PM -0700, Shuah Khan wrote:
> On 02/13/2018 06:33 PM, Darren Hart wrote:
> > On Tue, Feb 13, 2018 at 02:26:46PM -0700, Shuah Khan wrote:
> >> On 02/07/2018 10:24 AM, Daniel Díaz wrote:
> >>> The Makefile lacks a couple of line continuation backslashes
> >>> in an `if' clause, which produces an error while make'ing:
> >>>
> >>> $ make
> >>> make[1]: Entering directory `/[...]/linux/tools/testing/selftests/futex'
> >>> /bin/sh: -c: line 5: syntax error: unexpected end of file
> >>> make[1]: *** [all] Error 1
> >>> make[1]: Leaving directory `/[...]/linux/tools/testing/selftests/futex'
> >>> make: *** [all] Error 2
> >>>
> >
> > What is the failure scenario here? Is this shell specific? What does /bin/sh
> > point to for you?
>
> My understanding is that this problem is seen with make versions prior to 4.x.
> This specific problem is seen with make version 3.81
>
> I will let Daniel Díaz share details on his environment.
OK, thanks Shuah. I think this would be important to capture in the commit
message.
--
Darren Hart
VMware Open Source Technology Center