Re: [PATCH v7 31/37] MAINTAINERS: Add nds32

From: Greentime Hu
Date: Wed Feb 14 2018 - 00:55:43 EST


2018-02-14 0:02 GMT+08:00 Joe Perches <joe@xxxxxxxxxxx>:
> On Tue, 2018-02-13 at 17:09 +0800, Greentime Hu wrote:
>> Add a maintainer information for the nds32(Andes) architecture.
> []
>> diff --git a/MAINTAINERS b/MAINTAINERS
> []
>> @@ -868,6 +868,17 @@ X: drivers/iio/*/adjd*
>> F: drivers/staging/iio/*/ad*
>> F: drivers/staging/iio/trigger/iio-trig-bfin-timer.c
>>
>> +ANDES ARCHITECTURE
>> +M: Greentime Hu <green.hu@xxxxxxxxx>
>> +M: Vincent Chen <deanbo422@xxxxxxxxx>
>> +T: git https://github.com/andestech/linux.git
>> +S: Supported
>> +F: arch/nds32
>
> This should have a trailing /
>
> F: arch/nds32/

Thank you Joe.
I will add this trailing /
>
>> +F: Documentation/devicetree/bindings/interrupt-controller/andestech,ativic32.txt
>> +F: Documentation/devicetree/bindings/nds32

And here

>> +K: nds32
>
> Perhaps this should be
>
> K: \bnds32
>
> as there are some existing uses of nds32 in the current tree.
>
> or maybe case insensitive like
>
> K: (?i:\bnds32)
> or
> K: (?:\bnds32|\bNDS32)
>

I think it might be better to keep it "nds32" becaue some intrinsic
functions are defined with __nds32__xxx.