Re: [PATCH] lib/scatterlist: Add SG_CHAIN and SG_EMARK macros for LSB encodings

[Johannes Thumshirn]

On Wed, 2018-02-14 at 10:28 +0530, Anshuman Khandual wrote:
> This replaces scatterlist->page_link LSB encodings with SG_CHAIN and
> SG_EMARK definitions without any functional change.
> 
> Signed-off-by: Anshuman Khandual <khandual@xxxxxxxxxxxxxxxxxx>
> ---
> Âinclude/linux/scatterlist.h | 23 +++++++++++++----------
> Â1 file changed, 13 insertions(+), 10 deletions(-)
> 
> diff --git a/include/linux/scatterlist.h
> b/include/linux/scatterlist.h
> index 22b2131bcdcd..63d00bdb2fb3 100644
> --- a/include/linux/scatterlist.h
> +++ b/include/linux/scatterlist.h
> @@ -65,16 +65,18 @@ struct sg_table {
> Â */
> Â
> Â#define SG_MAGIC	0x87654321
> +#define SG_CHAIN	0x01
> +#define SG_EMARK	0x02

SG_EMARK sounds strange, what about SG_END?

-- 
Johannes Thumshirn                     ÂStorage
jthu
mshirn@xxxxxxx                Â+49 911 74053 689
SUSE
LINUX GmbH, Maxfeldstr. 5, 90409 NÃrnberg
GF: Felix ImendÃrffer, Jane
Smithard, Graham Norton
HRB 21284 (AG NÃrnberg)
Key fingerprint = EC38
9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850