Re: [PATCH] x86/apic: Move pending intr check code into it's own function

[Andy Shevchenko]

On Wed, Feb 14, 2018 at 8:24 AM, Dou Liyang <douly.fnst@xxxxxxxxxxxxxx> wrote:

Yes, I see you just moved the old code, but it might make sense to
update later the following.

> +                       for (j = 31; j >= 0; j--) {
> +                               if (value & (1<<j)) {

for_each_set_bit()

> +                                       ack_APIC_irq();
> +                                       acked++;
> +                               }
> +                       }

> +                       printk(KERN_ERR "LAPIC pending interrupts after %d EOI\n",
> +                              acked);

pr_err()

-- 
With Best Regards,
Andy Shevchenko