Re: [PATCH v2] PCI: qcom: add missing supplies required for msm8996

[Stanimir Varbanov]

On 02/14/2018 06:14 PM, Srinivas Kandagatla wrote:
> 
> 
> On 14/02/18 16:00, Stanimir Varbanov wrote:
>>> Â .../devicetree/bindings/pci/qcom,pcie.txtÂÂÂÂÂÂÂÂÂ |Â 4 ++++
>>> Â drivers/pci/dwc/pcie-qcom.cÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ | 24
>>> ++++++++++++++++++++--
>>> Â 2 files changed, 26 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.txt
>>> b/Documentation/devicetree/bindings/pci/qcom,pcie.txt
>>> index 3c9d321b3d3b..1fd703bd73e0 100644
>>> --- a/Documentation/devicetree/bindings/pci/qcom,pcie.txt
>>> +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.txt
>>> @@ -189,6 +189,10 @@
>>> ÂÂÂÂÂ Value type: <phandle>
>>> ÂÂÂÂÂ Definition: A phandle to the analog power supply for IC which
>>> generates
>>> ÂÂÂÂÂÂÂÂÂÂÂÂÂ reference clock
>>> +- vddpe-3v3-supply:
>> shouldn't it be vddpe_3v3-supply to be aligned with the other supplies?
>>
> I noticed that, I had to do it intentionally
> As dt properties should follow - instead of _

I don't agree with that. If the supply name is more than one word it
should be separated by underscore ('git grep \-supply' in dts files).

-- 
regards,
Stan