Re: [PATCH] siox: fix possible buffer overflow in device_add_store

From: Uwe Kleine-König
Date: Wed Feb 14 2018 - 12:00:30 EST


Hello,

On Wed, Feb 14, 2018 at 03:25:02PM +0100, Gavin Schenk wrote:
> Width 20 given in format string is larger than destination
> buffer 'type[20]', use %19s to prevent overflowing it.
>
> Fixes: bbecb07fa0af ("siox: new driver framework for eckelmann SIOX")
> Reported-by: David Binderman <dcb314@xxxxxxxxxxx>
> Signed-off-by: Gavin Schenk <g.schenk@xxxxxxxxxxxx>
Reviewed-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>

Thanks
Uwe

--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |