Re: [PATCH] platform/x86: ideapad-laptop: Increase timeout to wait for EC answer

From: Andy Shevchenko
Date: Wed Feb 14 2018 - 14:30:15 EST


On Sun, Feb 11, 2018 at 11:18 AM, Aaron Ma <aaron.ma@xxxxxxxxxxxxx> wrote:
> Lenovo E41-20 needs more time than 100ms to read VPC,
> the funtion keys always failed responding.
> Increase timeout to get the value from VPC, then
> the funtion keys like mic mute key work well.
>

Pushed to my review and testing queue, thanks!

> Signed-off-by: Aaron Ma <aaron.ma@xxxxxxxxxxxxx>
> ---
> drivers/platform/x86/ideapad-laptop.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/ideapad-laptop.c b/drivers/platform/x86/ideapad-laptop.c
> index 5b6f18b18801..535199c9e6bc 100644
> --- a/drivers/platform/x86/ideapad-laptop.c
> +++ b/drivers/platform/x86/ideapad-laptop.c
> @@ -113,7 +113,7 @@ MODULE_PARM_DESC(no_bt_rfkill, "No rfkill for bluetooth.");
> /*
> * ACPI Helpers
> */
> -#define IDEAPAD_EC_TIMEOUT (100) /* in ms */
> +#define IDEAPAD_EC_TIMEOUT (200) /* in ms */
>
> static int read_method_int(acpi_handle handle, const char *method, int *val)
> {
> --
> 2.14.3
>



--
With Best Regards,
Andy Shevchenko