Re: [PATCH v2 3/8] Convert virtio_console to kvzalloc_struct

From: Joe Perches
Date: Wed Feb 14 2018 - 15:19:55 EST


On Wed, 2018-02-14 at 12:11 -0800, Matthew Wilcox wrote:
> From: Matthew Wilcox <mawilcox@xxxxxxxxxxxxx>
>
> Signed-off-by: Matthew Wilcox <mawilcox@xxxxxxxxxxxxx>
> ---
> drivers/char/virtio_console.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c
> index 468f06134012..e0816cc2c6bd 100644
> --- a/drivers/char/virtio_console.c
> +++ b/drivers/char/virtio_console.c
> @@ -433,8 +433,7 @@ static struct port_buffer *alloc_buf(struct virtqueue *vq, size_t buf_size,
> * Allocate buffer and the sg list. The sg list array is allocated
> * directly after the port_buffer struct.
> */
> - buf = kmalloc(sizeof(*buf) + sizeof(struct scatterlist) * pages,
> - GFP_KERNEL);
> + buf = kvzalloc_struct(buf, sg, pages, GFP_KERNEL);
> if (!buf)
> goto fail;

kvfree?