Re: [PATCH v2 3/8] Convert virtio_console to kvzalloc_struct

From: Joe Perches
Date: Wed Feb 14 2018 - 15:30:47 EST


On Wed, 2018-02-14 at 12:28 -0800, Matthew Wilcox wrote:
> On Wed, Feb 14, 2018 at 12:19:47PM -0800, Joe Perches wrote:
> > On Wed, 2018-02-14 at 12:11 -0800, Matthew Wilcox wrote:
> > > */
> > > - buf = kmalloc(sizeof(*buf) + sizeof(struct scatterlist) * pages,
> > > - GFP_KERNEL);
> > > + buf = kvzalloc_struct(buf, sg, pages, GFP_KERNEL);
> > > if (!buf)
> >
> > kvfree?
>
> Yes, that would also need to be done. The point of these last six
> patches was to show the API in use, not for applying.

That's what RFC is for...