Re: [PATCH] staging: imx-media-vdic: fix inconsistent IS_ERR and PTR_ERR

[Gustavo A. R. Silva]

Hi all,

I was just wondering about the status of this patch.

Thanks
--
Gustavo

On 01/24/2018 06:14 PM, Steve Longerbeam wrote:
> Acked-by: Steve Longerbeam <steve_longerbeam@xxxxxxxxxx>
>
>
> On 01/23/2018 04:43 PM, Gustavo A. R. Silva wrote:
> > Fix inconsistent IS_ERR and PTR_ERR in vdic_get_ipu_resources.
> > The proper pointer to be passed as argument is ch.
> >
> > This issue was detected with the help of Coccinelle.
> >
> > Fixes: 0b2e9e7947e7 ("media: staging/imx: remove confusing 
> > IS_ERR_OR_NULL usage")
> > Signed-off-by: Gustavo A. R. Silva <gustavo@xxxxxxxxxxxxxx>
> > ---
> > Â drivers/staging/media/imx/imx-media-vdic.c | 2 +-
> > Â 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/media/imx/imx-media-vdic.c 
> > b/drivers/staging/media/imx/imx-media-vdic.c
> > index 433474d..ed35684 100644
> > --- a/drivers/staging/media/imx/imx-media-vdic.c
> > +++ b/drivers/staging/media/imx/imx-media-vdic.c
> > @@ -177,7 +177,7 @@ static int vdic_get_ipu_resources(struct vdic_priv 
> > *priv)
> > ÂÂÂÂÂÂÂÂÂ priv->vdi_in_ch = ch;
> > ÂÂÂÂÂÂÂÂÂ ch = ipu_idmac_get(priv->ipu, IPUV3_CHANNEL_MEM_VDI_NEXT);
> > -ÂÂÂÂÂÂÂ if (IS_ERR(priv->vdi_in_ch_n)) {
> > +ÂÂÂÂÂÂÂ if (IS_ERR(ch)) {
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂ err_chan = IPUV3_CHANNEL_MEM_VDI_NEXT;
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂ ret = PTR_ERR(ch);
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂ goto out_err_chan;