Re: [PATCH] drm/amdkfd: Use ARRAY_SIZE macro in kfd_build_sysfs_node_entry

[Oded Gabbay]

Hi Gustavo,
The patch is queued for the merge window of kernel 4.17 (opens in
about 7 weeks from now).

Oded

On Wed, Feb 14, 2018 at 11:30 PM, Gustavo A. R. Silva
<garsilva@xxxxxxxxxxxxxx> wrote:
> Hi all,
>
> I was just wondering about the status of this patch.
>
> Thanks
> --
> Gustavo
>
>
> On 01/19/2018 04:18 PM, Felix Kuehling wrote:
>>
>> Looks good. This change is Reviewed-by: Felix Kuehling
>> <Felix.Kuehling@xxxxxxx>
>>
>> Regards,
>>    Felix
>>
>>
>> On 2018-01-18 07:39 PM, Gustavo A. R. Silva wrote:
>>>
>>> Use ARRAY_SIZE instead of dividing sizeof array with sizeof an element.
>>>
>>> This issue was detected with the help of Coccinelle.
>>>
>>> Signed-off-by: Gustavo A. R. Silva <garsilva@xxxxxxxxxxxxxx>
>>> ---
>>>   drivers/gpu/drm/amd/amdkfd/kfd_topology.c | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
>>> b/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
>>> index c6a7609..7783250 100644
>>> --- a/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
>>> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
>>> @@ -677,7 +677,7 @@ static int kfd_build_sysfs_node_entry(struct
>>> kfd_topology_device *dev,
>>>         }
>>>         /* All hardware blocks have the same number of attributes. */
>>> -       num_attrs = sizeof(perf_attr_iommu)/sizeof(struct kfd_perf_attr);
>>> +       num_attrs = ARRAY_SIZE(perf_attr_iommu);
>>>         list_for_each_entry(perf, &dev->perf_props, list) {
>>>                 perf->attr_group = kzalloc(sizeof(struct kfd_perf_attr)
>>>                         * num_attrs + sizeof(struct attribute_group),
>>
>>
>