Re: [PATCH 3/3] percpu: allow select gfp to be passed to underlying allocators

From: Tejun Heo
Date: Thu Feb 15 2018 - 16:41:56 EST


Hello,

On Thu, Feb 15, 2018 at 10:08:16AM -0600, Dennis Zhou wrote:
> +/* the whitelisted flags that can be passed to the backing allocators */
> +#define gfp_percpu_mask(gfp) (((gfp) & (__GFP_NORETRY | __GFP_NOWARN)) | \
> + GFP_KERNEL)

Isn't there just one place where gfp comes in from outside? If so,
this looks like a bit of overkill. Can't we just filter there?

Thanks.

--
tejun