Re: [PATCH -mm 1/3] proc: randomize "struct pde_opener"

From: Alexey Dobriyan
Date: Thu Feb 15 2018 - 23:41:23 EST


On Thu, Feb 15, 2018 at 04:53:29PM -0800, Kees Cook wrote:
> On Wed, Feb 14, 2018 at 12:19 AM, Alexey Dobriyan <adobriyan@xxxxxxxxx> wrote:
> > The more the merrier.
>
> What made you choose this structure, BTW?

Nothing depends on its layout. No funky memcpy/memset...
It is strange you didn't annotate like 95% of structs.

> > @@ -177,7 +177,7 @@ struct pde_opener {
> > struct list_head lh;
> > bool closing;
> > struct completion *c;
> > -};
> > +} __randomize_layout;