Re: [PATCH] kconfig: clean-up reverse dependency help implementation

[Masahiro Yamada]

2018-02-21 20:14 GMT+09:00 Petr Vorel <petr.vorel@xxxxxxxxx>:
> Hi Masahiro,
>
>> This commit splits out the special E_OR handling ('-' instead of '||')
>> into a dedicated helper expr_print_revdev().
>
>> Restore the original expr_print() prior to commit 1ccb27143360
>> ("kconfig: make "Selected by:" and "Implied by:" readable").
>
>> This makes sense because:
>
>>   - We need to chop those expressions only when printing the reverse
>>     dependency, and only when E_OR is encountered
>
>>   - Otherwise, it should be printed as before, so fall back to
>>     expr_print()
>
>> This also improves the behavior; for a single line, it was previously
>> displayed in the same line as "Selected by", like this:
>
>>   Selected by: A [=n] && B [=n]
>
>> This will be displayed in a new line, consistently:
>
>>   Selected by:
>>   - A [=n] && B [=n]
>
>> Signed-off-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>
> Reviewed-by: Petr Vorel <pvorel@xxxxxxx>
>> ---
>
> <snip>
>
>>       get_symbol_props_str(r, sym, P_SELECT, _("  Selects: "));
>>       if (sym->rev_dep.expr) {
>> -             str_append(r, _("  Selected by: "));
>> +             str_append(r, _("  Selected by: \n"));
>                                        ^
> I'd remove unnecessary whitespace here ^.


I decided to not touch the text inside _( ... ) in this patch
although I do not think anybody translated "  Selected by: ".

I just moved str_append(r, "\n");

Anyway, this line will be removed soon.


Applied to linux-kbuild/kconfig.







>                 str_append(r, _("  Selected by:\n"));
>>               expr_gstr_print_revdep(sym->rev_dep.expr, r);
>> -             str_append(r, "\n");
>>       }
>
>>       get_symbol_props_str(r, sym, P_IMPLY, _("  Implies: "));
>>       if (sym->implied.expr) {
>> -             str_append(r, _("  Implied by: "));
>> +             str_append(r, _("  Implied by: \n"));
> The same here.
>
>>               expr_gstr_print_revdep(sym->implied.expr, r);
>> -             str_append(r, "\n");
>>       }
>
>>       str_append(r, "\n\n");
>
>
> Kind regards,
> Petr
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



-- 
Best Regards
Masahiro Yamada