Re: [PATCH] tools/memory-model: update: remove rb-dep, smp_read_barrier_depends, and lockless_dereference
From: Alan Stern
Date: Sat Feb 24 2018 - 11:49:28 EST
On Sat, 24 Feb 2018, Andrea Parri wrote:
> On Fri, Feb 23, 2018 at 07:30:13PM -0800, Paul E. McKenney wrote:
> > On Sat, Feb 24, 2018 at 12:22:24PM +0900, Akira Yokosawa wrote:
> > > On 2018/02/22 07:29:02 +0900, Akira Yokosawa wrote:
> > > > On 2018/02/22 2:15, Alan Stern wrote:
>
> [...]
>
> > > >>
> > > >> Akira pointed out some typos in the original patch, and he noted that
> > > >> cheatsheet.txt should be updated to indicate how unsuccessful RMW
> > > >> operations relate to address dependencies.
> > > >
> > > > My point was to separate unannotated loads from READ_ONCE(), if the
> > > > cheatsheet should concern such accesses as well.
> > > > Unsuccessful RMW operations were brought up by Andrea.
> > > >
> > >
> > > Paul, can you amend above paragraph in the change log to something like:
> > >
> > > Akira pointed out some typos in the original patch, and he noted that
> > > cheatsheet.txt should be updated to indicate READ_ONCE() implies
> > > address dependency, which invited Andrea's observation that it should
> > > also be updated to indicate how unsuccessful RMW operations relate to
> > > address dependencies.
> > >
> > > , if Alan and Andrea are OK with the amendment.
> > >
> > > Also, please append my Acked-by.
> > >
> > > Acked-by: Akira Yokosawa <akiyks@xxxxxxxxx>
> >
> > I can still amend this, and have added your Acked-by. If Alan and Andrea
> > OK with your change, I will apply that also.
>
> LGTM. Thanks,
Me too.
Alan