Re: [PATCH 5/5] selftests: futex Makefile add top level TAP header echo to RUN_TESTS

[Darren Hart]

On Fri, Feb 23, 2018 at 03:11:40PM -0700, Shuah Khan wrote:
> Add top level TAP header echo, testname and separator line to make
> the output consistent with the common run_tests target.

No objection to the changes, but I'll echo Ingo's request for a more
detailed justification for why these changes are warranted. We've seen
this a few times with recent changes to kselftests, I think too much
might be being assumed regarding the individual test author's tracking
of the core of the kselftests ongoing work.

> 
> Signed-off-by: Shuah Khan <shuahkh@xxxxxxxxxxxxxxx>
> ---
>  tools/testing/selftests/futex/Makefile | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/tools/testing/selftests/futex/Makefile b/tools/testing/selftests/futex/Makefile
> index cea4adcd42b8..3e9a9d7b4de1 100644
> --- a/tools/testing/selftests/futex/Makefile
> +++ b/tools/testing/selftests/futex/Makefile
> @@ -18,6 +18,9 @@ all:
>  	done
>  
>  override define RUN_TESTS
> +	@echo "TAP version 13";
> +	@echo "selftests: futex";
> +	@echo "========================================";
>  	@cd $(OUTPUT); ./run.sh
>  endef
>  
> -- 
> 2.14.1
> 
> 

-- 
Darren Hart
VMware Open Source Technology Center