Re: [PATCH] drm/amdkfd: Delete an error message for a failed memory allocation in kfd_topology_init()

[Oded Gabbay]

On Thu, Feb 8, 2018 at 11:33 PM, SF Markus Elfring
<elfring@xxxxxxxxxxxxxxxxxxxxx> wrote:
> From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> Date: Thu, 8 Feb 2018 22:23:57 +0100
>
> Omit an extra message for a memory allocation failure in this function.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> ---
>  drivers/gpu/drm/amd/amdkfd/kfd_topology.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_topology.c b/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
> index 19ce59028d6b..610e3d4ac575 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
> @@ -1019,7 +1019,6 @@ int kfd_topology_init(void)
>                 crat_image = kmalloc(image_size, GFP_KERNEL);
>                 if (!crat_image) {
>                         ret = -ENOMEM;
> -                       pr_err("No memory for allocating CRAT image\n");
>                         goto err;
>                 }
>                 ret = kfd_topology_get_crat_acpi(crat_image, &image_size);
> --
> 2.16.1
>

Hi,
Thanks for the patch but this code block is going to be refactored in
the next merge window and the patch will no longer be relevant.

Oded