Re: [PATCH 09/12] usb: roles: Add Intel XHCI USB role switch driver

From: Hans de Goede
Date: Sun Feb 25 2018 - 07:11:54 EST


Hi,

On 16-02-18 14:38, Heikki Krogerus wrote:
On Fri, Feb 16, 2018 at 11:47:48AM +0100, Hans de Goede wrote:
diff --git a/drivers/usb/Makefile b/drivers/usb/Makefile
index 060643a1b5c8..7d1b8c82b208 100644
--- a/drivers/usb/Makefile
+++ b/drivers/usb/Makefile
@@ -65,3 +65,5 @@ obj-$(CONFIG_USB_COMMON) += common/
obj-$(CONFIG_USBIP_CORE) += usbip/
obj-$(CONFIG_TYPEC) += typec/
+
+obj-$(CONFIG_USB_ROLE_SWITCH) += roles/
diff --git a/drivers/usb/roles/Kconfig b/drivers/usb/roles/Kconfig
new file mode 100644
index 000000000000..e5c2bfaf8ba5
--- /dev/null
+++ b/drivers/usb/roles/Kconfig
@@ -0,0 +1,14 @@
+if USB_ROLE_SWITCH
+
+config USB_ROLES_INTEL_XHCI
+ tristate "Intel XHCI USB Role Switch"
+ depends on ACPI && X86 && EXTCON

Hold on... There is no dependency on extcon, or is there?

You are right, this is an old leftover, removed for v2
of this patchset which I'm preparing atm.

Regards,

Hans