Re: [PATCH v3] drivers/virt: vm_gen_counter: initial driver implementation

[Randy Dunlap]

On 02/25/2018 07:55 AM, Or Idgar wrote:
> From: Or Idgar <oridgar@xxxxxxxxx>
> 
> This patch is a driver which expose the Virtual Machine Generation ID
> via sysfs. The ID is a UUID value used to differentiate between virtual
> machines.
> 
> The VM-Generation ID is a feature defined by Microsoft (paper:
> http://go.microsoft.com/fwlink/?LinkId=260709) and supported by multiple
> hypervisor vendors.
> 
> Signed-off-by: Or Idgar <oridgar@xxxxxxxxx>
> ---
> 
> Changes in v3 from v1 (v2 lack of patch changelog):
> - replaced GPL2 section with SPDX line.
> - including linux/kobject.h for hypervisor_kobj.
> - using acpi_os_map_memory instead acpi_os_map_iomem.
> 
>  Documentation/ABI/testing/sysfs-hypervisor |  13 +++
>  drivers/misc/Kconfig                       |   6 ++
>  drivers/misc/Makefile                      |   1 +
>  drivers/misc/vmgenid.c                     | 140 +++++++++++++++++++++++++++++
>  4 files changed, 160 insertions(+)
>  create mode 100644 Documentation/ABI/testing/sysfs-hypervisor
>  create mode 100644 drivers/misc/vmgenid.c

$Subject says drivers/virt/. Please choose one.

> diff --git a/drivers/misc/vmgenid.c b/drivers/misc/vmgenid.c
> new file mode 100644
> index 000000000000..6b7ec9bd45e8
> --- /dev/null
> +++ b/drivers/misc/vmgenid.c
> @@ -0,0 +1,140 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Virtual Machine Generation ID driver
> + *
> + * Copyright (C) 2018 Red Hat, Inc. All rights reserved.
> + *	Authors:
> + *	  Or Idgar <oridgar@xxxxxxxxx>
> + *	  Gal Hammer <ghammer@xxxxxxxxxx>
> + *
> + */
> +#include <linux/init.h>
> +#include <linux/module.h>
> +#include <linux/kernel.h>
> +#include <linux/kobject.h>
> +#include <linux/acpi.h>
> +#include <linux/uuid.h>
> +
> +MODULE_LICENSE("GPL");
> +MODULE_AUTHOR("Or Idgar <oridgar@xxxxxxxxx>");
> +MODULE_AUTHOR("Gal Hammer <ghammer@xxxxxxxxxx>");
> +MODULE_DESCRIPTION("Virtual Machine Generation ID");
> +MODULE_VERSION("0.1");
> +
> +ACPI_MODULE_NAME("vmgenid");
> +
> +static u64 phy_addr;

Minor nit:
I would prefer phys_addr since we also have PHY devices that have a phy addr.

thanks,
-- 
~Randy