Re: [PATCH] m68k/mac: Fix apparent race condition in Baboon interrupt dispatch

[Geert Uytterhoeven]

On Sun, Jan 28, 2018 at 12:51 AM, Finn Thain <fthain@xxxxxxxxxxxxxxxxxxx> wrote:
> The algorithm used in baboon_irq() appears to be subject to a race
> condition: an IRQ flag could be lost if asserted between the MOV
> instructions from and to the interrupt flag register. However,
> testing shows that the write to the flag register has no effect.
> Rewrite this loop to remove the apparent race condition.
>
> No-one seems to know how to clear Baboon IRQ flags, or whether
> that's even possible, so add a comment about this.
>
> Tested-by: Stan Johnson <userm57@xxxxxxxxx>
> Signed-off-by: Finn Thain <fthain@xxxxxxxxxxxxxxxxxxx>

Thanks, applied and queue for v4.17.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds