Re: [PATCH v3 00/12] USB Type-C device-connection, mux and switch support
From: Andy Shevchenko
Date: Mon Feb 26 2018 - 06:39:50 EST
On Mon, Feb 26, 2018 at 1:19 PM, Hans de Goede <hdegoede@xxxxxxxxxx> wrote:
> On 26-02-18 11:59, Andy Shevchenko wrote:
>> On Mon, Feb 26, 2018 at 11:09 AM, Hans de Goede <hdegoede@xxxxxxxxxx>
>> wrote:
>> Didn't have time to comment on v2, so here we are:
>> you are using in even the same file two styles, i.e. IS_ERR_OR_NULL
>> vs. !x || IS_ERR(x) (and negative ones).
> Good catch, I only see this in "usb: common: Small class for USB role
> switches",
> will fix for v4.
>
>> Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
> So with the above fixed I can apply your reviewed-by to the entire series?
Right.
--
With Best Regards,
Andy Shevchenko