RE: [PATCH 4/8] efi: Decode UEFI-defined IA32/X64 Error Structure GUIDs

[Ghannam, Yazen]

> -----Original Message-----
> From: Ard Biesheuvel [mailto:ard.biesheuvel@xxxxxxxxxx]
> Sent: Saturday, February 24, 2018 11:41 AM
> To: Ghannam, Yazen <Yazen.Ghannam@xxxxxxx>
> Cc: linux-efi@xxxxxxxxxxxxxxx; Linux Kernel Mailing List <linux-
> kernel@xxxxxxxxxxxxxxx>; Borislav Petkov <bp@xxxxxxx>; the arch/x86
> maintainers <x86@xxxxxxxxxx>
> Subject: Re: [PATCH 4/8] efi: Decode UEFI-defined IA32/X64 Error Structure
> GUIDs
> 
> On 23 February 2018 at 20:03, Yazen Ghannam
> <Yazen.Ghannam@xxxxxxx> wrote:
> > From: Yazen Ghannam <yazen.ghannam@xxxxxxx>
> >
> > For easier handling, match the known IA32/X64 error structure GUIDs to
> > enums.
> >
> > Also, print out the name of the matching Error Structure Type.
> >
> > GUIDs taken from UEFI 2.7 section N.2.4.2.1 IA32/X64 Processor Error
> > Information Structure.
> >
> > Cc: <stable@xxxxxxxxxxxxxxx> # 4.16.x
> > Signed-off-by: Yazen Ghannam <yazen.ghannam@xxxxxxx>
> > ---
> >  drivers/firmware/efi/cper-x86.c | 41
> +++++++++++++++++++++++++++++++++++++++++
> >  1 file changed, 41 insertions(+)
> >
> > diff --git a/drivers/firmware/efi/cper-x86.c b/drivers/firmware/efi/cper-
> x86.c
> > index 9d608f742c98..3b86223bdb67 100644
> > --- a/drivers/firmware/efi/cper-x86.c
> > +++ b/drivers/firmware/efi/cper-x86.c
> > @@ -14,17 +14,53 @@
...
> >  void cper_print_proc_ia(const char *pfx, const struct cper_sec_proc_ia
> *proc)
> >  {
> >         int i;
> >         struct cper_ia_err_info *err_info;
> >         char newpfx[64];
> > +       enum err_types err_type;
> >
> 
> Can you make this an u8 please? The signedness of an enum is not well
> defined, and you only check the upper bound below.
> 

Yes, will do.

Thanks,
Yazen