Re: [PATCH v6 4/5] fuse: Ensure posix acls are translated outside of init_user_ns

From: Eric W. Biederman
Date: Mon Feb 26 2018 - 11:36:01 EST


Miklos Szeredi <mszeredi@xxxxxxxxxx> writes:

> On Thu, Feb 22, 2018 at 11:50 PM, Eric W. Biederman
> <ebiederm@xxxxxxxxxxxx> wrote:
>
>> So if we could figure out how to use the generic acl support for the old
>> brand of fuse filesystems that don't set FUSE_POSIX_ACL it would be much
>> easier to support them long term.
>
> Simplest and most robust way seems to be to do everything the same (as
> with FUSE_POSIX_ACL) but tell the vfs not to cache the acl.

Good point. That sounds like for the !fc->posix_acl case we just
need a careful use of "forget_all_cached_acls(inode)".

I will take a quick look at that, and see if that is easy/sufficient to
cover the legacy fuse case. Otherwise I will go with what I already
have here.

That feels like a better path. And internally I would call what is
today fc->posix_acl fc->cached_posix_acl. To better convey the intent.
Fingers crossed.

Eric