Re: Fwd: Re: Kernel panic with 4.16-rc1 (and 4.16-rc2) running selftest
From: Khalid Aziz
Date: Mon Feb 26 2018 - 12:06:13 EST
On 02/23/2018 06:15 PM, Matthew Wilcox wrote:
On Fri, Feb 23, 2018 Randy Dunlap wrote:
[add Matthew Wilcox; hopefully he can look/see]
Thanks, Randy. I don't understand why nobody else thought to cc the
author of the patch that it was bisected to ...
Sorry, Willy. That was my fault. I should have cc'd you to begin with.
Please try this patch. It fixes ffe00000, but there may be more things
tested that it may not work for.
This patch fixes the problem. I do not see kernel panics with this patch
any more.
--
Khalid
Chris Mi, what happened to that set of testcases you promised to write
for me?
diff --git a/lib/idr.c b/lib/idr.c
index c98d77fcf393..10d9b8d47c33 100644
--- a/lib/idr.c
+++ b/lib/idr.c
@@ -36,8 +36,8 @@ int idr_alloc_u32(struct idr *idr, void *ptr, u32 *nextid,
{
struct radix_tree_iter iter;
void __rcu **slot;
- int base = idr->idr_base;
- int id = *nextid;
+ unsigned int base = idr->idr_base;
+ unsigned int id = *nextid;
if (WARN_ON_ONCE(radix_tree_is_internal_node(ptr)))
return -EINVAL;