Re: [PATCH v4 01/12] drivers: base: Unified device connection lookup

From: Randy Dunlap
Date: Mon Feb 26 2018 - 14:35:05 EST


On 02/26/2018 10:39 AM, Hans de Goede wrote:
> diff --git a/include/linux/connection.h b/include/linux/connection.h
> new file mode 100644
> index 000000000000..0b4430eae53a
> --- /dev/null
> +++ b/include/linux/connection.h
> @@ -0,0 +1,33 @@
> +// SPDX-License-Identifier: GPL-2.0
> +
> +#ifndef _LINUX_CONNECTION_H_
> +#define _LINUX_CONNECTION_H_
> +
> +#include <linux/list.h>
> +
> +struct device;
> +
> +/**
> + * struct devcon - Device Connection Descriptor
> + * @endpoint: The names of the two devices connected together
> + * @id: Unique identifier for the connection

Hi,
* @list: <description>
is missing above.

> + */
> +struct devcon {
> + const char *endpoint[2];
> + const char *id;
> + struct list_head list;
> +};


--
~Randy