Re: [PATCH 3/3] platform/x86: dell-smbios: Link all dell-smbios-* modules together

From: Andy Shevchenko
Date: Tue Feb 27 2018 - 11:16:56 EST


On Tue, Feb 27, 2018 at 6:13 PM, <Mario.Limonciello@xxxxxxxx> wrote:

>> > --- a/drivers/platform/x86/dell-smbios.h
>> > +++ b/drivers/platform/x86/dell-smbios.h
>> > @@ -75,4 +75,10 @@ int dell_laptop_register_notifier(struct notifier_block
>> *nb);
>> > int dell_laptop_unregister_notifier(struct notifier_block *nb);
>> > void dell_laptop_call_notifier(unsigned long action, void *data);
>> >
>> > +/* for the supported backends */
>> > +int init_dell_smbios_wmi(void);
>> > +void exit_dell_smbios_wmi(void);
>> > +int init_dell_smbios_smm(void);
>> > +void exit_dell_smbios_smm(void);
>> > +
>>
>> ...here...
>
> So do you mean you would rather see inline functions in header
> file for the #else case then?

At least is sounds as a standard practice to me.

--
With Best Regards,
Andy Shevchenko