Re: [PATCH 3/3] ARM: mach-stm32: Add Extended TrustZone Protection driver

[Benjamin Gaignard]

2018-02-27 18:14 GMT+01:00 Mark Rutland <mark.rutland@xxxxxxx>:
> On Tue, Feb 27, 2018 at 03:09:26PM +0100, Benjamin Gaignard wrote:
>  +
>> +static const u32 stm32mp1_ip_addr[] = {
>> +     0x5c008000,     /* 00 stgenc */
>> +     0x54000000,     /* 01 bkpsram */
>> +     0x5c003000,     /* 02 iwdg1 */
>> +     0x5c000000,     /* 03 usart1 */
>> +     0x5c001000,     /* 04 spi6 */
>> +     0x5c002000,     /* 05 i2c4 */
>
> ...
>
> This duplicates information that is in the DT, which is unfortunate.

Yes I would have prefer to be able to get this information from etzpc
hardware itself
but that isn't the case so I need this table to found the status bits
of each device.

>
> Why can these not be marked disabled inthe DT instead?
>
> If it's dynamic form boot-to-boot, then the FW can probe this prior to
> entering Linux, and patch the DT appropriately.

I know that is one software way to do, but let discusted about that in
cover letter thread.

Thanks,
Benjamin

>
> Thanks,
> Mark.