Re: [PATCH v2 3/3] objtool: use global host flags for compilation

[Josh Poimboeuf]

On Tue, Feb 27, 2018 at 09:55:23PM +0100, Robin Jarry wrote:
> 2018-02-27, Josh Poimboeuf:
> > On Mon, Feb 26, 2018 at 07:41:48PM +0100, Robin Jarry wrote:
> [snip]
> > >  ifdef CONFIG_STACK_VALIDATION
> > >    has_libelf := $(call try-run,\
> > > -		echo "int main() {}" | $(HOSTCC) -xc -o /dev/null -lelf -,1,0)
> > > +	echo "int main() {}" | $(HOSTCC) $(HOSTLDFLAGS) -xc -o /dev/null -lelf -,1,0)
> > 
> > This should probably also have HOSTCFLAGS, since the objtool makefile
> > uses it as well.
> 
> I had intentionally omitted HOSTCFLAGS since the compiled code does not
> contain any #include statements (only -lelf). But adding them cannot
> hurt.

Ah, right.  The point of this check is to see if it can find libelf, so
I guess using HOSTCFLAGS wouldn't have a point here.  So it's fine the
way it is.

-- 
Josh