Re: [PATCH] x86: devicetree: enable multiprocessing and interrupt setting in DT

From: Thomas Gleixner
Date: Wed Feb 28 2018 - 04:07:20 EST


On Mon, 26 Feb 2018, Ivan Gorinov wrote:

> The x86-specific Device Tree implementation only supported single CPU,
> and IRQ allocation from DT parameters was broken in recent versions.

Was broken is not really informative. Please describe in which way it was
broken.

>
> This change enables multiprocessing and fixes broken IRQ allocation.

Please split this into two parts:

1) Fix the broken IRQ mechanics
2) Enable SMP parsing

> Signed-off-by: Ivan Gorinov <ivan.gorinov@xxxxxxxxx>
> ---
>  arch/x86/kernel/devicetree.c | 41 ++++++++++++++++++++++++++++++++++-------
>  1 file changed, 34 insertions(+), 7 deletions(-)
>
> diff --git a/arch/x86/kernel/devicetree.c b/arch/x86/kernel/devicetree.c
> index 25de5f6..f885eab 100644
> --- a/arch/x86/kernel/devicetree.c
> +++ b/arch/x86/kernel/devicetree.c
> @@ -130,6 +130,29 @@ static void __init dtb_setup_hpet(void)
>  #endif

patching file arch/x86/kernel/devicetree.c
patch: **** malformed patch at line 25:  #endif

Your patch is white space damaged by your mail client.

See Documentation/process/email-clients.rst:Evolution (GUI)

Thanks,

tglx