Re: [PATCH v3] Documentation: Update ncurses package names for menuconfig

[Randy Dunlap]

On 02/28/2018 01:32 PM, Arvind Prasanna wrote:
> The package name is ncurses-devel for Redhat based distros
> and libncurses-dev for Debian based distros.
> 
> Signed-off-by: Arvind Prasanna <arvindprasanna@xxxxxxxxx>

Thanks. Looks good to me.

Acked-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>


> ---
> 
> Changes in v3:
> - Fix a package name in the commit message.
> 
> Changes in v2:
> - Add a missing echo as pointed out by one of the reviewers.
> 
>  scripts/kconfig/lxdialog/check-lxdialog.sh | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
>  scripts/kconfig/lxdialog/check-lxdialog.sh | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/scripts/kconfig/lxdialog/check-lxdialog.sh b/scripts/kconfig/lxdialog/check-lxdialog.sh
> index a10bd9d..6c0bcd9 100755
> --- a/scripts/kconfig/lxdialog/check-lxdialog.sh
> +++ b/scripts/kconfig/lxdialog/check-lxdialog.sh
> @@ -55,7 +55,8 @@ EOF
>  	    echo " *** required header files."                            1>&2
>  	    echo " *** 'make menuconfig' requires the ncurses libraries." 1>&2
>  	    echo " *** "                                                  1>&2
> -	    echo " *** Install ncurses (ncurses-devel) and try again."    1>&2
> +	    echo " *** Install ncurses (ncurses-devel or libncurses-dev " 1>&2
> +	    echo " *** depending on your distribution) and try again."    1>&2
>  	    echo " *** "                                                  1>&2
>  	    exit 1
>  	fi
> 


-- 
~Randy