RE: [PATCH V4 2/2] thermal: imx: add i.MX7 thermal sensor support

[Anson Huang]

Anson Huang
Best Regards!


> -----Original Message-----
> From: Leonard Crestez [mailto:leonard.crestez@xxxxxxx]
> Sent: Thursday, March 1, 2018 1:26 AM
> To: Anson Huang <anson.huang@xxxxxxx>; rui.zhang@xxxxxxxxx;
> edubezval@xxxxxxxxx; shawnguo@xxxxxxxxxx
> Cc: dl-linux-imx <linux-imx@xxxxxxx>; linux-pm@xxxxxxxxxxxxxxx;
> devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; robh+dt@xxxxxxxxxx; Mark Rutland
> <mark.rutland@xxxxxxx>; Fabio Estevam <fabio.estevam@xxxxxxx>;
> linux@xxxxxxxxxxxxxxx; kernel@xxxxxxxxxxxxxx; Lothar WaÃmann
> <LW@xxxxxxxxxxxxxxxxxxx>
> Subject: Re: [PATCH V4 2/2] thermal: imx: add i.MX7 thermal sensor support
> 
> On Sat, 2018-02-24 at 16:02 +0800, Anson Huang wrote:
> > This patch adds i.MX7 thermal sensor support, most of the i.MX7
> > thermal sensor functions are same with
> > i.MX6 except the registers offset/layout, so we move those registers
> > offset/layout definitions to soc data structure.
> >
> > i.MX7 uses single calibration data @25C, the calibration data is
> > located at OCOTP offset 0x4F0, bit[17:9], the formula is as below:
> >
> > Tmeas = (Nmeas - n1) + 25; n1 is the fuse value for 25C.
> >
> > Signed-off-by: Anson Huang <Anson.Huang@xxxxxxx>
> > Signed-off-by: Bai Ping <ping.bai@xxxxxxx>
> 
> On imx7d (also 6sx and 6ul) OCOTP read will hang silently if the ocotp clk is not
> enabled. For example this can happen if imx_thermal is built as a module or
> probes after unused clocks are disabled.
> 
> This driver has support for reading ocotp values through the ocotp nvmem
> driver (which handles clks properly). Since imx7d is a new compatible string for
> upstream maybe you could just make new-style bindings mandatory and drop
> the changes toÂimx_init_from_tempmon_data?
> 
> SeeÂcommit 2067b757e972 ("ARM: dts: imx6ul: Add imx6ul-tempmon")


It makes sense, I sent out V5 to drop the direct OCOTP register access support, all OCOTP reading will
Be through ocotp nvmem driver on i.MX7D.

Anson.

> 
> --
> Regards,
> Leonard