Re: [PATCH 07/12] bus: ti-sysc: Handle some devices in omap_device compatible way

From: Tony Lindgren
Date: Wed Feb 28 2018 - 19:37:24 EST


* Tony Lindgren <tony@xxxxxxxxxxx> [180223 21:03]:
> Now that ti-sysc can manage child devices, we must also be backwards
> compatible with the current omap_device code. With omap_device, we
> assume that the child device manages the interconnect target module
> directly.
...
> /* At this point the module is configured enough to read the revision */
> static int sysc_init_module(struct sysc *ddata)
> {
> int error;
>
> + if (ddata->cfg.quirks & (SYSC_QUIRK_NO_IDLE_ON_INIT |
> + SYSC_QUIRK_NO_RESET_ON_INIT)) {
> + ddata->revision = sysc_read_revision(ddata);
> + goto rev_quirks;
> + }
> +
> error = pm_runtime_get_sync(ddata->dev);
> if (error < 0) {
> pm_runtime_put_noidle(ddata->dev);

This needs to use only SYSC_QUIRK_NO_IDLE_ON_INIT to skip PM
runtime. Otherwise the module may not be enabled when it is
being accessed.

Updated patch below.

Regards,

Tony

8< -------------------