Re: [PATCH] f2fs: fix to restore whint_mode in ->remount_fs

From: Chao Yu
Date: Wed Feb 28 2018 - 21:50:52 EST


Hi Jaegeuk,

On 2018/3/1 10:45, Jaegeuk Kim wrote:
> On 02/28, Chao Yu wrote:
>> From: Chao Yu <yuchao0@xxxxxxxxxx>
>>
>> If we fail in ->remount_fs, it needs to restore old whint_mode as other
>> mount options.
>>
>> Fixes: e25afe01822f ("f2fs: support passing down write hints given by users to block layer")
>
> Hi Chao,
>
> It was not merged, so please allow me to integrate this into the original
> patch.

No problem, please go ahead. ;)

Thanks,

>
> Thanks,
>
>> Signed-off-by: Chao Yu <yuchao0@xxxxxxxxxx>
>> ---
>> fs/f2fs/super.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
>> index 89abe4087e66..8a93f78efca2 100644
>> --- a/fs/f2fs/super.c
>> +++ b/fs/f2fs/super.c
>> @@ -1512,6 +1512,7 @@ static int f2fs_remount(struct super_block *sb, int *flags, char *data)
>> sbi->s_qf_names[i] = s_qf_names[i];
>> }
>> #endif
>> + sbi->whint_mode = old_whint_mode;
>> sbi->mount_opt = org_mount_opt;
>> sbi->active_logs = active_logs;
>> sb->s_flags = old_sb_flags;
>> --
>> 2.14.1.145.gb3622a4ee
>
> .
>