Re: [PATCH 11/12] PM / AVS: SmartReflex: Prepare to use device tree based probing
From: Kevin Hilman
Date: Wed Feb 28 2018 - 22:07:32 EST
Tony Lindgren <tony@xxxxxxxxxxx> writes:
> We are currently probing smartreflex with omap_device while we are
> already probing smartreflex related interconnect target module with
> ti-sysc driver and dts data.
>
> Before we can flip things on for ti-sysc, we need to prepare the
> smartreflex driver a bit:
>
> 1. The smartreflex clock is really for the whole interconnect target
> module. So it may be configured at the parent device level with
> ti-sysc
>
> 2. With ti-sysc, we have the child device manage interconnect target
> module directly if pm_runtime_irq_safe() is set and there is only
> one child. In that case nobody else is going to call pm_runtime_get
> and put, so we need to add these calls to idle smartreflex properly
> after probe if not fully configured
>
> 3. With ti-sysc, the parent driver may rebind. So we want to use
> platform_driver_register() and don't want probe to be __init
>
> Note that this patch depends on the related changes to ti-sysc driver
> and omap_device probing to prevent both ti-sysc and omap_device to
> try to probe smartreflex.
>
> Cc: linux-pm@xxxxxxxxxxxxxxx
> Cc: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
> Signed-off-by: Tony Lindgren <tony@xxxxxxxxxxx>
Acked-by: Kevin Hilman <khilman@xxxxxxxxxxxx>
I don't have anything else queued for this driver, so feel free to take
it along with the rest of the series.
Kevin