Re: [PATCH v4] Input: gpio_keys: Add level trigger support for GPIO keys

[Andy Shevchenko]

On Thu, Mar 1, 2018 at 9:36 AM, Baolin Wang <baolin.wang@xxxxxxxxxx> wrote:
> On some platforms (such as Spreadtrum platform), the GPIO keys can only
> be triggered by level type. So this patch introduces one trigger_type to
> indicate if the button's interrupt type is level trigger or edge trigger.

>                         button->irq =
>                                 irq_of_parse_and_map(to_of_node(child), 0);

AFAIU, 0 means NO_IRQ, thus,

> +                       if (button->irq)
> +                               button->trigger_type =
> +                                       irq_get_trigger_type(button->irq);

irq_get_trigger_type(NO_IRQ) should return 0.

Therefore, if (button->irq) is redundant.
Did I miss anything?

-- 
With Best Regards,
Andy Shevchenko