Re: [PATCH 2/6] kbuild: add dtc as dependency on .dtb files

From: Masahiro Yamada
Date: Thu Mar 01 2018 - 09:05:09 EST


2018-03-01 22:28 GMT+09:00 Rob Herring <robh@xxxxxxxxxx>:
> On Wed, Feb 28, 2018 at 11:45 PM, Masahiro Yamada
> <yamada.masahiro@xxxxxxxxxxxxx> wrote:
>> 2018-03-01 13:33 GMT+09:00 Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>:
>>> 2018-03-01 8:32 GMT+09:00 Rob Herring <robh@xxxxxxxxxx>:
>>>> If dtc is rebuilt, we should rebuild .dtb files with the new dtc.
>>>>
>>>> Cc: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>
>>>> Signed-off-by: Rob Herring <robh@xxxxxxxxxx>
>>>
>>>
>>> Hmm, I am not 100% sure about this.
>>>
>>> Is there a case where resulted DTBs
>>> depend on DTC version?
>>>
>>>
>>> If I understand correctly,
>>> DTS and DTB are 1:1
>>> Unlike CC, there is no room for optimization.
>>
>>
>> Maybe I was wrong.
>>
>> Is there room for optimization
>> in 'DT strings' section?
>
> Not sure.
>
>> I guess it is optimized enough to avoid string duplication,
>> but there could be different results
>> without changing the specification.
>
> What I care about is rebuilding so new warnings get emitted especially
> when developing those checks. Right now I have to manually delete the
> dtb files each time.
>

Fair enough.
Probably, it is better to make sure all DTB are compiled
by the latest DTC.

Please go ahead.
Seemed already queued up :-)


Acked-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>



--
Best Regards
Masahiro Yamada