Re: [PATCH v2 2/3] x86: devicetree: enable multiprocessing in DT

[Andy Shevchenko]

On Thu, Mar 1, 2018 at 4:45 AM, Ivan Gorinov <ivan.gorinov@xxxxxxxxx> wrote:
> Adding code to register processors described in Device Tree.
> APIC ID is specified in 'intel-apic_id' propery as used in U-Boot.
> First address specified in 'reg' is used as default APIC ID.

> +       version = GET_APIC_VERSION(apic_read(APIC_LVR));
> +       for_each_node_by_type(dn, "cpu") {
> +               prop = of_get_property(dn, "intel,apic-id", NULL);
> +               if (prop) {
> +                       apic_id = be32_to_cpup(prop);
> +               } else {
> +                       ret = of_address_to_resource(dn, 0, &r);

> +                       if (WARN_ON(ret))

Wouldn't be too much?

Options:
- add _ONCE
- convert to plain pr_warn()

> +                               continue;
> +                       apic_id = r.start;
> +               }
> +               generic_processor_info(apic_id, version);
> +       }


-- 
With Best Regards,
Andy Shevchenko