Re: [PATCH 1/2] ARM: dts: imx6: RDU2: Add RAVE SP device

[Andrey Smirnov]

On Tue, Feb 27, 2018 at 10:31 PM, Shawn Guo <shawnguo@xxxxxxxxxx> wrote:
> On Mon, Feb 26, 2018 at 06:49:41AM -0800, Andrey Smirnov wrote:
>> With MFD and watchdog drivers for RAVE SP device support added by
>> 538ee27290fa ("mfd: Add driver for RAVE Supervisory Processor") and
>> c3bb33345721 ("watchdog: Add RAVE SP watchdog driver") add
>> corresponding DT node for RDU2.
>>
>> Cc: Rob Herring <robh+dt@xxxxxxxxxx>
>> Cc: Mark Rutland <mark.rutland@xxxxxxx>
>> Cc: Shawn Guo <shawnguo@xxxxxxxxxx>
>> Cc: Fabio Estevam <fabio.estevam@xxxxxxx>
>> Cc: Guenter Roeck <linux@xxxxxxxxxxxx>
>> Cc: Chris Healy <cphealy@xxxxxxxxx>
>> Cc: Lucas Stach <l.stach@xxxxxxxxxxxxxx>
>> Cc: devicetree@xxxxxxxxxxxxxxx
>> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
>> Cc: linux-kernel@xxxxxxxxxxxxxxx
>> Signed-off-by: Andrey Smirnov <andrew.smirnov@xxxxxxxxx>
>> ---
>>  arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi | 11 +++++++++++
>>  1 file changed, 11 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
>> index 72f52fcecee1..460931089509 100644
>> --- a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
>> +++ b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
>> @@ -305,6 +305,17 @@
>>       pinctrl-names = "default";
>>       pinctrl-0 = <&pinctrl_uart4>;
>>       status = "okay";
>> +
>> +     rave-sp {
>> +             compatible = "zii,rave-sp-rdu2";
>> +             current-speed = <1000000>;
>> +             status = "okay";
>
> The okay status is to flip the state of devices that are initially
> disabled.  I think it's unnecessary for the case here.

Good point, will respin v2 without that bit shortly.

Thanks,
Andrey Smirnov