Re: [PATCH] fs/UBIFS: make 'sum' definition closer to where it is used

From: Richard Weinberger
Date: Thu Mar 01 2018 - 11:25:03 EST

Next message: Loic Pallardy: "[PATCH v3 05/13] remoteproc: add helper function to allocate and init rproc_mem_entry struct"
Previous message: Loic Pallardy: "[PATCH v3 11/13] remoteproc: create vdev subdevice with specific dma memory pool"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Am Mittwoch, 28. Februar 2018, 03:42:03 CET schrieb Liu Song:
> Local var sum is only used in one branch, and it may be not used if
> it is defined outside the branch. Try to move the definition into
> the branch to make it closer to where it is actually used.

Does this fix a problem?
I'm not a huge fan of defining variables in the middle of functions unless it
makes the code really better.

Thanks,
//richard

Next message: Loic Pallardy: "[PATCH v3 05/13] remoteproc: add helper function to allocate and init rproc_mem_entry struct"
Previous message: Loic Pallardy: "[PATCH v3 11/13] remoteproc: create vdev subdevice with specific dma memory pool"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]