Re: [PATCH 8/9] ASoC: Intel: bytcr_rt5640: Drop unwanted ignore_suspend settings

[Hans de Goede]

Hi,

On 01-03-18 17:48, Mark Brown wrote:
> On Thu, Mar 01, 2018 at 05:26:06PM +0100, Hans de Goede wrote:
> > On 01-03-18 17:22, Mark Brown wrote:
> > > On Sun, Feb 18, 2018 at 11:01:45PM +0100, Hans de Goede wrote:
>
> > > > The ignore_suspend settings were added in an attempt to try and fix
> > > > suspend / resume issues. But they never fully fixed these and now we've
> > > > a proper fix, so lets remove these.
>
> > > Do these systems not have the ability to continue to play audio through
> > > suspend using the DSP?  That's the sort of thing that ignore_suspend is
> > > normally used for.
>
> > In theory yes, in practice if we keep ignore_suspend set then we get
> > audio for a couple of more seconds after suspend until the buffers
> > are empty, as we have no code keeping them filled, which is not really
> > useful, since we don't support this in a meaningful way it is better
> > to just do a normal full suspend.
>
> That sounds like what's missing is hookup of whatever the DSP uses to
> wake the system when it's getting to the bottom of the buffer?  That's
> the normal way this stuff is implemented anyway.

I'm afraid there is a lot more missing, at least from a standard Linux
distro pov, just waking up is not enough, we need to also wakeup
userspace to get the mp3-player (or whatever) to refill the buffer,
but preferably without waking up the GPU, turning on the screen, etc.

AFAIK support for this is currently completely missing, standard Linux
userspace currently treats suspend-2-idle as a a full suspend and any
wakeup as a full wakeup.

So AFAICT currently the ignore-suspend flag is currently not useful
and as the commit message mentions IIRC there were added to fix some
issues with suspend/resume in the past.

Regards,

Hans