Re: [PATCH 4/6] scripts/dtc: generate lexer and parser during build instead of shipping

[Rob Herring]

On Wed, Feb 28, 2018 at 10:34 PM, Masahiro Yamada
<yamada.masahiro@xxxxxxxxxxxxx> wrote:
> 2018-03-01 8:32 GMT+09:00 Rob Herring <robh@xxxxxxxxxx>:
>> Now that the kernel build supports flex and bison, remove the _shipped
>> files and generate them during the build instead.
>>
>> Based on Masahiro's original patch.
>>
>> Cc: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>
>> Signed-off-by: Rob Herring <robh@xxxxxxxxxx>
>> ---
>>  scripts/dtc/Makefile                 |    6 +-
>>  scripts/dtc/dtc-lexer.lex.c_shipped  | 2259 ---------------------------------
>>  scripts/dtc/dtc-parser.tab.c_shipped | 2321 ----------------------------------
>>  scripts/dtc/dtc-parser.tab.h_shipped |  125 --
>>  scripts/dtc/update-dtc-source.sh     |    5 -
>
>
>
>
> As you know, this introduces
> scripts/dtc/dtc-parser.y: warning: 3 shift/reduce conflicts [-Wconflicts-sr]
> then, the next commit will fix it.
>
> I do not have a strong opinion about the parch order.
> It would be ridiculous to update *_shipped
> that will be immediately removed.  So, probably this is OK.
>
>
>
> FWIW.
>
> This is completely out of realm of my field since
> I speak Japanese in my daily life.
>
> Is it better to change
> the 'singular vs plural' in the comment block?
>
>
> # This script assumes that the dtc and the linux git trees are in the
> # same directory. After building dtc in the dtc directory, it copies the
> # source files and generated source files into the scripts/dtc directory
> # in the kernel and creates a git commit updating them to the new
> # version.
>
>
> After this commit, 'version_gen.h' will be the only generated file.
> "generated source files" sounds like we have more.

You are right as we do have that hidden generated file. I worry
changing it could become stale too if we add more generated files
sometime in the future. I've changed it to "generated source file(s)"
to cover both cases. Not sure that's really proper English grammar,
but it is widely used.

> Please take it FWIW.
> I am just nit-picking
> according to what I learned at junior high school, which might be wrong.
>
>
>
> Otherwise,
>
> Reviewed-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>

Thanks.