Re: [PATCH 1/3] extcon: gpio: Localize platform data
From: Chanwoo Choi
Date: Thu Mar 01 2018 - 18:36:52 EST
Hi,
On 2018ë 03ì 01ì 18:14, Linus Walleij wrote:
> On Mon, Feb 12, 2018 at 9:53 AM, Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
>
>> Nothing in the entire kernel #includes <linux/extcon/extcon-gpio.h>
>> so move the platform data declaration inside of the driver.
>>
>> Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
>
> No reply on these patches so far,
> if you prefer I can just apply them to the GPIO
> tree.
I'm sorry for late reply. The extcon-gpio.c should be solved
how to to get the unique id such as EXTCON_USB, EXTCON_DISP_HDMI and so on.
As you knew, you already tried to develop it with device-tree.
But, it is not accepted.
Even if extcon-gpio.c has a problem still to get the extcon id,
I'll apply this series. Because I don't want to remove extcon-gpio.c
and you need to clean-up the gpio library. On later, I'll try to fix this issue.
I added the 'FIXME' comment which explains the extcon_id issue
and then applied this series.
--
Best Regards,
Chanwoo Choi
Samsung Electronics