Re: [PATCH 0/29] arm meltdown fix backporting review for lts 4.9

From: Alex Shi
Date: Fri Mar 02 2018 - 04:15:17 EST




On 03/01/2018 11:24 PM, Greg KH wrote:
> On Wed, Feb 28, 2018 at 11:56:22AM +0800, Alex Shi wrote:
>> Hi All,
>>
>> This backport patchset fixed the meltdown issue, it's original branch:
>> https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git/log/?h=kpti
>> A few dependency or fixingpatches are also picked up, if they are necessary
>> and no functional changes.
>>
>> The patchset also on repository:
>> git://git.linaro.org/kernel/linux-linaro-stable.git lts-4.9-spectrevv2
>>
>> No bug found yet from kernelci.org and lkft testing.
>
> No bugs is good, but does it actually fix the meltdown problem? What
> did you test it on?

Oh, I have no A73/A75 cpu, so I can not reproduce meltdown bug.

>
> And why are you making this patchset up? What is wrong with the patches
> in the android-common tree for this?

We believe the LTS is the base kernel for android/lsk, so the fixing
patches should get it first and then merge to other tree.

>
>> Any comments are appreciated!
>
> You need to start versioning this changeset, as I have no idea if this
> is the "latest" one or not, right?>
> Or have you not sent out this patchset before? How does this interact
> with the "spectre" patches? Or am I totally confused here?

It is the first patchset for meltdown. Yes, I will resent this patchset
with versioning after the renesas board booting fixed.

The meltdown and spectre is 2 different bugs, the fixing patchset are
isolated each other. So I did the backport as 2 different patchset. And
merging them together is relative simple. I will comming with a merge
patch next time, after the meltdown patchset ready.(the kernelci didn't
works well in recent days)

Thanks
Alex