Re: [PATCH] efi: make const array 'apple' static

[Ard Biesheuvel]

On 2 March 2018 at 14:35, Colin King <colin.king@xxxxxxxxxxxxx> wrote:
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> Don't populate the const read-only array 'buf' on the stack but instead
> make it static. Makes the object code smaller by 64 bytes:
>
> Before:
>    text    data     bss     dec     hex filename
>    9264       1      16    9281    2441 arch/x86/boot/compressed/eboot.o
>
> After:
>    text    data     bss     dec     hex filename
>    9200       1      16    9217    2401 arch/x86/boot/compressed/eboot.o
>
> (gcc version 7.2.0 x86_64)
>
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Thanks Colin

Queued in efi-next.


> ---
>  arch/x86/boot/compressed/eboot.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/boot/compressed/eboot.c b/arch/x86/boot/compressed/eboot.c
> index 886a9115af62..f2251c1c9853 100644
> --- a/arch/x86/boot/compressed/eboot.c
> +++ b/arch/x86/boot/compressed/eboot.c
> @@ -423,7 +423,7 @@ static void retrieve_apple_device_properties(struct boot_params *boot_params)
>
>  static void setup_quirks(struct boot_params *boot_params)
>  {
> -       efi_char16_t const apple[] = { 'A', 'p', 'p', 'l', 'e', 0 };
> +       static efi_char16_t const apple[] = { 'A', 'p', 'p', 'l', 'e', 0 };
>         efi_char16_t *fw_vendor = (efi_char16_t *)(unsigned long)
>                 efi_table_attr(efi_system_table, fw_vendor, sys_table);
>
> --
> 2.15.1
>