Re: [PATCH] ARM: dts: tpc: Device tree description of the TPC board

[Lukasz Majewski]

Hi Fabio,

> Hi Lukasz,
> 
> In addition to Sascha's comments:

Thanks for your input - please see my reply below.

> 
> On Fri, Mar 2, 2018 at 9:17 AM, Lukasz Majewski <lukma@xxxxxxx> wrote:
> 
> > diff --git a/arch/arm/boot/dts/imx6q-kp-tpc.dts
> > b/arch/arm/boot/dts/imx6q-kp-tpc.dts new file mode 100644
> > index 000000000000..955462e778c9
> > --- /dev/null
> > +++ b/arch/arm/boot/dts/imx6q-kp-tpc.dts
> > @@ -0,0 +1,84 @@
> > +/*
> > + * Copyright 2018
> > + * Lukasz Majewski, DENX Software Engineering, lukma@xxxxxxx
> > + *
> > + * This file is dual-licensed: you can use it either under the
> > terms
> > + * of the GPL or the X11 license, at your option. Note that this
> > dual
> > + * licensing only applies to this file, and not this project as a
> > + * whole.
> > + *
> > + *  a) This file is licensed under the terms of the GNU General
> > Public
> > + *     License version 2.  This program is licensed "as is" without
> > + *     any warranty of any kind, whether express or implied.
> > + *
> > + * Or, alternatively,
> > + *
> > + *  b) Permission is hereby granted, free of charge, to any person
> > + *     obtaining a copy of this software and associated
> > documentation
> > + *     files (the "Software"), to deal in the Software without
> > + *     restriction, including without limitation the rights to use,
> > + *     copy, modify, merge, publish, distribute, sublicense, and/or
> > + *     sell copies of the Software, and to permit persons to whom
> > the
> > + *     Software is furnished to do so, subject to the following
> > + *     conditions:
> > + *
> > + *     The above copyright notice and this permission notice shall
> > be
> > + *     included in all copies or substantial portions of the
> > Software.
> > + *
> > + *     THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY
> > KIND,
> > + *     EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE
> > WARRANTIES
> > + *     OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
> > + *     NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
> > + *     HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
> > + *     WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> > + *     FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE
> > OR
> > + *     OTHER DEALINGS IN THE SOFTWARE.
> > + */
> > +  
> 
> Please consider using SPDX tag instead.

Ok.

> 
> > +/dts-v1/;
> > +
> > +#include "imx6q-kp.dtsi"
> > +
> > +/ {
> > +       model = "Freescale i.MX6 Quad K+P TPC Board";
> > +       compatible = "fsl,imx6q-tpc", "fsl,imx6q";  
> 
> Use the board manufacturer symbol instead.
> 
> If needed, add an entry for the vendor at
> Documentation/devicetree/bindings/vendor-prefixes.txt

I see.

> 
> > +};
> > +
> > +&lcd_display {
> > +       display-timings {
> > +               800x480x60 {
> > +                       clock-frequency = <34209000>;
> > +                       hactive = <800>;
> > +                       vactive = <480>;
> > +                       hback-porch = <85>;
> > +                       hfront-porch = <15>;
> > +                       vback-porch = <34>;
> > +                       vfront-porch = <10>;
> > +                       hsync-len = <28>;
> > +                       vsync-len = <1>;
> > +                       hsync-active = <1>;
> > +                       vsync-active = <1>;
> > +                       de-active = <1>;
> > +               };
> > +       };
> > +};  
> 
> We prefer to use a compatible panel entry instead of keeping the panel
> timings inside the dts.

Previously (for other imx6q board) I've added entry to e.g.
panel-simple.c file [1] to describe the display.

I thought that adding timings to DTS is more welcome - hence we do not
need to add any extra code to Linux when porting new board?

> 
> > +
> > +&ipu1_di0_disp0 {
> > +       remote-endpoint = <&lcd_display_in>;
> > +};
> > +
> > +&can1 {
> > +       status = "disabled";
> > +};
> > +
> > +&can2 {
> > +       status = "disabled";
> > +};
> > +
> > +&uart1 {
> > +       status = "okay";
> > +};
> > +
> > +&uart2 {
> > +       status = "disabled";
> > +};
> > diff --git a/arch/arm/boot/dts/imx6q-kp.dtsi
> > b/arch/arm/boot/dts/imx6q-kp.dtsi new file mode 100644
> > index 000000000000..47a10fb1d46b
> > --- /dev/null
> > +++ b/arch/arm/boot/dts/imx6q-kp.dtsi
> > @@ -0,0 +1,468 @@
> > +/*
> > + * Copyright 2018
> > + * Lukasz Majewski, DENX Software Engineering, lukma@xxxxxxx
> > + *
> > + * This file is dual-licensed: you can use it either under the
> > terms
> > + * of the GPL or the X11 license, at your option. Note that this
> > dual
> > + * licensing only applies to this file, and not this project as a
> > + * whole.
> > + *
> > + *  a) This file is licensed under the terms of the GNU General
> > Public
> > + *     License version 2.  This program is licensed "as is" without
> > + *     any warranty of any kind, whether express or implied.
> > + *
> > + * Or, alternatively,
> > + *
> > + *  b) Permission is hereby granted, free of charge, to any person
> > + *     obtaining a copy of this software and associated
> > documentation
> > + *     files (the "Software"), to deal in the Software without
> > + *     restriction, including without limitation the rights to use,
> > + *     copy, modify, merge, publish, distribute, sublicense, and/or
> > + *     sell copies of the Software, and to permit persons to whom
> > the
> > + *     Software is furnished to do so, subject to the following
> > + *     conditions:
> > + *
> > + *     The above copyright notice and this permission notice shall
> > be
> > + *     included in all copies or substantial portions of the
> > Software.
> > + *
> > + *     THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY
> > KIND,
> > + *     EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE
> > WARRANTIES
> > + *     OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
> > + *     NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
> > + *     HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
> > + *     WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> > + *     FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE
> > OR
> > + *     OTHER DEALINGS IN THE SOFTWARE.
> > + */  
> 
> SPDX, please.

The other upstreamed imx6q board used dual license - GPLv2 or X11
(which is also called MIT license).

I suppose that this license header shall be replaced with:

SPDX-License-Identifier: (GPL-2.0+ OR MIT)

Am I correct?

> 
> 
> > +       leds {
> > +               compatible = "gpio-leds";
> > +
> > +               green {
> > +                       label = "led1";
> > +                       gpios = <&gpio3 16 0>;  
> 
> gpios = <&gpio3 16 GPIO_ACTIVE_HIGH>;
> 
> > +                       linux,default-trigger = "gpio";
> > +                       default-state = "off";
> > +               };
> > +
> > +               red {
> > +                       label = "led0";
> > +                       gpios = <&gpio3 23 0>;  
> 
> GPIO_ACTIVE_HIGH

Ok.

> 
> > +                       linux,default-trigger = "gpio";
> > +                       default-state = "off";
> > +               };
> > +       };
> > +
> > +       memory: memory {
> > +               reg = <0x10000000 0x40000000>;
> > +       };  
> 
>  memory@10000000 otherwise warnings are seen when building with W=1.
> 
> Make sure that building the dtb with W=1 introduces no warnings.

Ok. Thanks for pointing this out.

> 
> > +&i2c1 {
> > +       clock-frequency = <400000>;
> > +       pinctrl-names = "default";
> > +       pinctrl-0 = <&pinctrl_i2c1>;
> > +       status = "okay";
> > +
> > +       goodix_ts@5d {
> > +               compatible = "goodix,gt911";
> > +               reg = <0x5d>;
> > +
> > +               pinctrl-names = "default";
> > +               pinctrl-0 = <&pinctrl_ts>;
> > +  
> 
> No need for these blank lines.

Ok.

> 
> > +               interrupt-parent = <&gpio1>;
> > +               interrupts = <9 2>;  
> 
> Please use an IRQ flag.
> 
> > +               irq-gpios = <&gpio1 9 0>;  
> 
> GPIO_ACTIVE_HIGH
> 
> > +               reset-gpios = <&gpio5 2 0>;  
> 
> GPIO_ACTIVE_HIGH.
> 
> > +&i2c2 {
> > +       clock-frequency = <400000>;
> > +       pinctrl-names = "default";
> > +       pinctrl-0 = <&pinctrl_i2c2>;
> > +       status = "okay";
> > +
> > +       codec: sgtl5000@a {
> > +               compatible = "fsl,sgtl5000";
> > +               #sound-dai-cells = <0>;
> > +               reg = <0x0a>;
> > +
> > +               pinctrl-names = "default";
> > +               pinctrl-0 = <&pinctrl_codec>;
> > +  
> 
> No need for these blank lines.
> 
> > +               clocks = <&clks IMX6QDL_CLK_CKO>;
> > +               VDDA-supply = <&reg_3p3v>;
> > +               VDDIO-supply = <&reg_3p3v>;  
> 
> > +&uart2 {
> > +       pinctrl-names = "default";
> > +       pinctrl-0 = <&pinctrl_uart2>;
> > +       fsl,uart-has-rtscts;  
> 
>  fsl,uart-has-rtscts has been deprecated. Please use  uart-has-rtscts
> instead.

Ok.


Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@xxxxxxx

Attachment: pgpS_C9DjWbGF.pgp
Description: OpenPGP digital signature